Skip to content

win64/msvc: large or oddly-sized types pass by-ref #29012

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Oct 15, 2015

Conversation

tari
Copy link
Contributor

@tari tari commented Oct 13, 2015

Fixes #28676.

There doesn't seem to be a good way to add a test for this, but I tested the repro in #28676 and confirmed it now yields the correct result.

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

I think a test can be added for this by perhaps modifying src/rt/rust_test_helpers.c or enabling an existing test on Windows (it may be ignored somewhere), perhaps that could validate this fix?

@tari
Copy link
Contributor Author

tari commented Oct 14, 2015

Nothing relevant that was ignored on windows, so added a function to rust_test_helpers and a test case to exercise it.

@luqmana
Copy link
Member

luqmana commented Oct 14, 2015

@bors: r+

I'll add more tests as part of #27017 since this plus some changes should unblock it on that end. Thanks!

@bors
Copy link
Collaborator

bors commented Oct 14, 2015

📌 Commit 95721d3 has been approved by luqmana

bors added a commit that referenced this pull request Oct 15, 2015
Fixes #28676.

There doesn't seem to be a good way to add a test for this, but I tested the repro in #28676 and confirmed it now yields the correct result.
@bors
Copy link
Collaborator

bors commented Oct 15, 2015

⌛ Testing commit 95721d3 with merge eafe106...

@bors bors merged commit 95721d3 into rust-lang:master Oct 15, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants